fix: publish --stage-tags missing generated tags #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemiller
force-pushed
the
fix/stage-tags
branch
from
f2ac498
to
c95a0bc
Compare
|
ping |
The `--stage-tags FILE` flag is only including the tags explicitly set as positional args to `apko publish`. Any tags generated by `--package-version-tag/stem` are not included. The `additionalTags` slice is empty when this code is reached. Instead of shadowing `allTags` slice generated just before this step we can use it. It includes a de-duped set of tags that includes both explicit tags from the command line and any generated/discovered tags that come from package-version and stemming. Signed-off-by: joe miller <joeym@joeym.net>
joemiller
force-pushed
the
fix/stage-tags
branch
from
c95a0bc
to
9844a45
Compare
kaniini
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--stage-tags FILEflag is only including the tags explicitly set as positional args toapko publish. Any tags generated by--package-version-tag/stemare not included.The
additionalTagsslice is empty when this code is reached. Instead we can use theallTagsslice generated just before this step instead of shadowing it.allTagsincludes a de-duped set of tags that includes both explicit tags from the command line and any generated/discovered tags that come from package-version and stemming.